Use generated Protobuf commit for conformance - #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
Workflow run 32354714323 failed in both OTP and Elixir matrix jobs while building the upstream Protobuf checkout. The selected commit fell between a runtime header change and its generated files.
Fix
Select the newest
protocolbuffers/protobufmaincommit whose message starts withAuto-generate files. This keeps generated sources and runtime headers from separate upstream commits together.Validation
mix test: 629 passed, 2 skipped, 9 excludedmix format --check-formatted: passedprotocandconformance_test_runner: passed at selected commit80d472933a06bf050b471584164be4bf2dee57a3